Keyhan Vakil
Keyhan Vakil
### Version v19.0.0-pre ### Platform Linux 19-Ubuntu SMP Wed Jun 22 17:44:56 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ### Subsystem buffer ### What steps will reproduce the bug? 1. Clone...
If `--max-old-space-size` is passed on the command line, it takes precedence over `resourceLimits.maxOldSpaceSizeMb` passed to the worker thread. IMO this is a bug, but seems unlikely to change(?), so let's...
This introduces some code to convert from V8's test JSON output to JUnit XML. We need this because V8's latest refactor of their test runner has made it difficult to...
### What version of pprof are you using? `go tool pprof` with go1.18.3. Full go env output GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/keyhan/.cache/go-build" GOENV="/home/keyhan/.config/go/env" GOEXE="" GOEXPERIMENT="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GOMODCACHE="/home/keyhan/go/pkg/mod" GONOPROXY=""...
This: sw x0 (4)x1 should be an error.
This: lw s0 s1 does not produce any errors.
`llnode` was a great tool to have. Unfortunately it is currently unmaintained and so it has been removed from the diagnostic tooling list, see nodejs/node#43289. ## Why `llnode` is good...
With this diff, our tests are much better. Previously they were entirely failing on Node 16. Now: * `stack-test` passes (12/12) * `inspect-test` mostly passes (57/59) * `frame-test` somewhat passes...
Old versions of Ubuntu (and likely other LTS distros) have `git` versions which do not support `git-sparse-checkout`. `git-sparse-checkout` is used as of #389. Dynamically check if `git sparse-checkout` is supported,...
I disabled this in #404. This is a PR so I can futz around with it and try to figure out why the mirror isn't working.