Erik Faye-Lund

Results 123 comments of Erik Faye-Lund
trafficstars

The gerrit MR is just sitting there without any progress. Reopening this for visibility.

I think this is a case where the CTS failure reports can be deceiving. There's several cases where the lines gets verified multiple times with different arguments, and the CTS...

What exact test is failing here? I wonder if the problem is really that we forget to check for `VK_LINE_RASTERIZATION_MODE_LAST` when the rasterization mode is unset? There's some tests that...

OK, so both of those tests use `VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT` and the test is skipped if `strictLines` isn't `true`. The spec says: > `VK_LINE_RASTERIZATION_MODE_DEFAULT` is equivalent to `VK_LINE_RASTERIZATION_MODE_RECTANGULAR` if [VkPhysicalDeviceLimits](https://registry.khronos.org/vulkan/specs/latest/html/vkspec.html#VkPhysicalDeviceLimits)::strictLines is VK_TRUE,...

OK, so this time there's a single dash missing (top right corner) compared to the expectations... I think I've seen some code that tries to deal with different clipping modes...

OK, looking more at the log here: - The test passes the first two iterations: ```xml Rendering 4 lines(s): (width = 5) Line 1: (0.01, 0, 0, 1) (0.5, 0.2,...

Oooh, this is a problem where the whole sharedEdge stuff is bogus for the line segments after merging them. We should do this on top: ```patch @@ -1129,7 +1149,7 @@...

@souravpNV: Just curious: Does the test pass if you *only* apply the current version of tge "Merge consecutive lines when stippling"-patch from Gerrit but do *not* apply " Respect strictness...

OK, thanks for chiming in on that. In that case, I think I'll withdraw that specific patch, and leave it with the smallest set.

I'm something similar here as well. It seems even full-screen support in general is broken; I'm getting a windowed X11 Window instead of a full-screen window when specifying a monitor...