Erik Faye-Lund

Results 66 comments of Erik Faye-Lund

Do you mean to imply that works made WITH glsl-sandbox implicitly gets a licence attached? I doubt that would even be legal...

I don't think we can legally force a license upon other people's work. The way I understand licensing, it has to be a conscious decision by the copyright holder. But...

Makes sense to me, both.

My interpretation is that it's not legal to use unlicensed materials for any particular purpose without explicit permission from the author. You should contact the authors of the shaders you...

Wow, that's awesome. One very minor nit though: the newly added static/js/numberslider.js doesn't end with a new-line, which will confuse some text-editors.

Is this solving the same problem as #4178?

Minus those one (or two) nit(s) above, this looks pretty good to me.

@yupferris: Yeah... We should probably make the CI report the size of the stand-alone player (or TestPlayer) or something, so we always know what's going on there. It's tempting to...

Mind explaining what exactly this helps with? Size? Performance? I'm not against or anything, just curious what motivated the the increased amount of code...

I meant the source code size, yeah. More source code means a higher maintenance burden. Usually, it's hard to beat an import in terms of size, at least for 64k...