kumavis

Results 248 comments of kumavis
trafficstars

@ZitRos how would you detect binary vs maybe chinese

thanks. this makes it possible to do the non-eval "templated Compartment eval" / "precompiled module" thing that we need to do for metamask `__makeScopeProxy__` and `__isKnownScopeProxy__` are to be removed...

my biggest regret is that the diff is a bit difficult to review, but I think the result is easy to review and audit @mhofman the `test-scope.js` file (previously `test-scope-handler.js`)...

split the `scopeTerminator` into a reuseable strict and per-evaluator sloppyGlobals version

> I'm having a hard time reviewing the tests because of the combined rename + modifications past the diff threshold. Would appreciate a minimal rename and separate modification to the...

looks like `[email protected]` doesn't know how to parse `[email protected]` ``` WARNING in /home/xyz/Development/lavamoat/node_modules/clone-deep/utils.js 7:34-41 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted...

due to this lazy cache mechanism https://npmfs.com/package/clone-deep/0.2.4/utils.js#L10

relevant PRs https://github.com/jonschlinkert/merge-deep/pull/12 https://github.com/jonschlinkert/merge-deep/pull/14 https://github.com/jonschlinkert/merge-deep/pull/9

@doowb more info over here :+1:

fwiw just tested the latest versions and they worked with the current `merge-deep` source for my basic json merging needs - `[email protected]` - `[email protected]` - `[email protected]` not sure what breaking...