kumavis

Results 258 comments of kumavis

```js lockdown({ overrideTaming, errorTaming: 'unsafe', stackFiltering: 'verbose', consoleTaming: 'unsafe' }); console.log(Object.getOwnPropertyDescriptors(Error.prototype)); ``` - min: ``` { constructor: { value: [Function: Error], writable: false, enumerable: false, configurable: false }, name: {...

first `'%ErrorPrototype%': { constructor: true }` breaks the logging of errors adding `'%ObjectPrototype%': { 'constructor': true }` fixes the logging of errors

trace https://github.com/nodejs/node/blob/7633c86eebbf6e381e60e63dc6e3eb36a3cce276/lib/internal/util/inspect.js#L286 https://github.com/nodejs/node/blob/7633c86eebbf6e381e60e63dc6e3eb36a3cce276/lib/internal/util/inspect.js#L726 https://github.com/nodejs/node/blob/7633c86eebbf6e381e60e63dc6e3eb36a3cce276/lib/internal/util/inspect.js#L796 https://github.com/nodejs/node/blob/7633c86eebbf6e381e60e63dc6e3eb36a3cce276/lib/internal/util/inspect.js#L554 why `constructor` as getter is problematic ^ for: - `(no relevant enablements)` constructor is `'Error'` https://github.com/nodejs/node/blob/7633c86eebbf6e381e60e63dc6e3eb36a3cce276/lib/internal/util/inspect.js#L803 for: - `'%ErrorPrototype%': { constructor: true }` constructor is...

this api may allow us to customize and fix output https://github.com/nodejs/node/blob/7633c86eebbf6e381e60e63dc6e3eb36a3cce276/lib/internal/util/inspect.js#L294-L304

neat hack, if you add a `constructor` property on the `Error` instance, it will log correctly in node ```js Object.defineProperty(err, 'constructor', { value: Error }) ```

additionally SES does not support versions of js that dont support Symbol

heres some platform apis react-native sets up, good targets for attenuation https://github.com/facebook/react-native/blob/73108477589a18cecb303ef556fa3da02f8ca1b8/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp#L85-L137

@erights the incompatibilites can all be addressed by configuring or modifying react-native/metro, and ensuring ses itself is not transformed. so maybe we can close these issues. these were uncovered as...