Yoshiya Hinosawa comments

Results 644 comments of


                                            Yoshiya Hinosawa

feat(http/cookie): add set-cookie headers parser

CI failures look irrelevant to this PR. I'll look into that

Consider adding "testing/expect.ts" module

@TomokiMiyauci Have you made any progress on this? Is there anything we can help on it?

Consider adding "testing/expect.ts" module

@TomokiMiyauci Yes, I think we still need this because Deno-first implementation is better than jest or chai via `npm:` specifier in several ways (less dependencies, less downloads, better typings, etc)....

feature request: base58 encoding

implemented in #2539

refactor(encoding): making column argument optional

@luk3skyw4lker > it would be a breaking change anyway, because for it to be available even with the overloading, I have to change the order of the function parameters, so...

refactor(encoding): making column argument optional

We also introduced a few breaking changes to `encoding/csv` recently, but we didn't receive much response from the community. https://github.com/denoland/deno_std/pull/2536 https://github.com/denoland/deno_std/pull/2491 I think it's still relatively safe to make breaking...

tech(testing): Add conditional type check utils

closing in favor of #2864 Thanks @Duelsik for the initial work!

test: `serveDirectory TLS` and `serveDirIndex TLS` are flaky

It's really strange to see this flakiness. We check the child process prints `Listening` to stdout. So the child process should be ready for serving http requests, but `Deno.connectTls` call...

Don't unnecessarily request to read environment variable

Right, we can't use top-level-await in `std/node` for compatibility issues. One option to solve this might be, in my view, to introduce `Deno.permissions.querySync` in Deno CLI, and use that before...

WIP: Test on other then file, dir or link.

@clemens-tolboom I think the issue was that `Deno.run` call wasn't awaited correctly. I fixed that in https://github.com/denoland/deno_std/pull/1793/commits/fa5f8c59b50c65cd4e92e098ef4464931c71ddb9 (by using Deno.spawn, which is newer version of Deno.run). Now I think this...