Yoshiya Hinosawa

Results 644 comments of Yoshiya Hinosawa

@timonson I've looked at test cases of serveFile, and in some cases it returns `Response` object with error status code. Does it make sense to your use cases to return...

1 should be now fixed in deno_std https://github.com/denoland/deno_std/pull/2676

`std/semver` mirrors most APIs of https://github.com/npm/node-semver > Some features ,^0.2.3 := >=0.2.3

This seems to have started from https://github.com/denoland/deno/pull/14319 (compared `3d1123f8b09cecfa57a93d8b8b7d19af2b45f070` and `1c05e41f37da022971f0090b2a92e6340d230055` with `deno upgrade --canary --version `) seems like a problem of reading file

Reduced the reproducing example to the single file. The following script creates a example txt file (`data.txt`), start the server, makes a request, compares the file digest on server and...

> but it seems like the idea to modify a shared buffer in-place is somehow breaking things? Looks like `iterateReader` reuses the shared underlying buffer object for all outputs and...

The bug itself seems having existed from the beginning https://github.com/denoland/deno/pull/1130/files#diff-1f62e23971d4281e275c4e80b39ed60ac6f0b71b14bba6d92e4decf790ad53e1R129 (Note: - iterateReader was renamed from iter in https://github.com/denoland/deno_std/pull/813 - iter in std was migrated from Deno.iter in https://github.com/denoland/deno_std/pull/843 -...

Let's document in JSDoc comment. I also think it's better to document when `length` is meaningful. Do all digest algorithms respect length property? (I guess no)

I'll work on `fs.access` https://nodejs.org/api/fs.html#fsaccesspath-mode-callback