deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

feature request: base58 encoding

Open harrysolovay opened this issue 1 year ago • 2 comments

The base58 encoding scheme has become quite popular for a number of use cases. Any thoughts on including a standard implementation in this lib?

harrysolovay avatar Jul 18 '22 02:07 harrysolovay

I think it makes sense to add

crowlKats avatar Jul 18 '22 03:07 crowlKats

Also taking this one!

luk3skyw4lker avatar Jul 28 '22 19:07 luk3skyw4lker

Hello, is anyone currently working on this? New around these parts. Correct me if I am wrong and someone else is working on the issue still.

I did not see a standard implementation of Go to port over. https://github.com/denoland/deno_std/tree/main/encoding is the correct location for adding the exported deno stand library functionality of the encoding and test files placed in the same directory?

ghost avatar Aug 02 '22 10:08 ghost

@mtmulch1 I am currently working on this issue still but this would be the right directory to add the implementation files.

luk3skyw4lker avatar Aug 02 '22 11:08 luk3skyw4lker

Hi @luk3skyw4lker, wondering if there are any updates on this front? It seems others (@mtmulch1) may be interested in implementing this as well.

harrysolovay avatar Aug 08 '22 05:08 harrysolovay

I found another issue in this repository this one is all yours.

ghost avatar Aug 08 '22 07:08 ghost

Hello @harrysolovay

I'm still finishing the work, there are still some details but I'm planning to open a PR this weekend to finish it

luk3skyw4lker avatar Aug 11 '22 13:08 luk3skyw4lker

BTW, sorry to take so long!

luk3skyw4lker avatar Aug 11 '22 13:08 luk3skyw4lker

@luk3skyw4lker I appreciate you taking on this work –– thank you!

harrysolovay avatar Aug 12 '22 04:08 harrysolovay

Hi everyone! It wasn't able for me to open a PR last weekend, but I'm still working on the issue. During the week I keep tangled at work and usually am not able to work here or provide updates, I mostly do the work at weekends, I think that this weekend I'll be able to surely open the PR

luk3skyw4lker avatar Aug 19 '22 19:08 luk3skyw4lker

implemented in #2539

kt3k avatar Aug 25 '22 05:08 kt3k

@luk3skyw4lker thank you so much for seeing this through. Very excited to use this.

harrysolovay avatar Aug 25 '22 06:08 harrysolovay

@harrysolovay you're welcome! If there is any bug you can open an issue and tag me already

luk3skyw4lker avatar Aug 25 '22 13:08 luk3skyw4lker