std/node/fs missing a lot of functionality

[AliBasicCoder]

so, the problem is std/node/fs is missing a lot of functions:

EDIT: some were done

50/56

• [x] fs.createReadStream
• [x] fs.createWriteStream
• [x] fs.fdatasync
• [x] fs.fdatasyncSync
• [x] fs.fstat
• [x] fs.fstatSync
• [x] fs.fsync
• [x] fs.fsyncSync
• [x] fs.ftruncate
• [x] fs.ftruncateSync
• [x] fs.futimes
• [x] fs.futimesSync
• [ ] fs.lchmod
• [ ] fs.lchmodSync
• [ ] fs.lutimes
• [ ] fs.lutimesSync
• [x] fs.link
• [x] fs.linkSync
• [x] fs.lstat
• [x] fs.lstatSync
• [x] fs.mkdtemp
• [x] fs.mkdtempSync
• [x] fs.open
• [x] fs.opendir
• [x] fs.opendirSync
• [x] fs.read (with it's to overwrites)
• [x] fs.readdir
• [x] fs.readdirSync
• [x] fs.readSync (with it's to overwrites)
• [ ] fs.readv
• [ ] fs.readvSync
• [x] fs.realpath
• [x] fs.realpath.native
• [x] fs.realpathSync
• [x] fs.realpathSync.native
• [x] fs.rename
• [x] fs.renameSync
• [x] fs.rmdir
• [x] fs.rmdirSync
• [x] fs.stat
• [x] fs.statSync
• [x] fs.symlink
• [x] fs.symlinkSync
• [x] fs.truncate
• [x] fs.truncateSync
• [x] fs.unlink
• [x] fs.unlinkSync
• [x] fs.unwatchFile
• [x] fs.utimes
• [x] fs.utimesSync
• [x] fs.watch
• [x] fs.watchFile
• [x] fs.write (with it's to overwrites)
• [x] fs.writeSync (with it's to overwrites)
• [x] fs.writev
• [x] fs.writevSync

[AliBasicCoder]

i noticed that Deno.symlink doesn't exist ??

[ry]

symlink is unstable https://doc.deno.land/builtin/unstable#Deno.symlink

[AliBasicCoder]

see denoland/deno#7666

[Liamolucko]

Some of these have now been implemented, here's an updated checklist:

(Update(@kt3k): Removed the list of APIs with checkboxes here. We keep updating the list above)

[lp]

I would grab some, for a start I would go with mkdtemp/mkdtempSync. Anybody already on the case?

[majidsajadi]

@kt3k I see you updated this comment. i guess link and linkSync are implemented too.

I will send some PR`s for:

• [x] fs.fdatasync
• [x] fs.fdatasyncSync
• [x] fs.fstat
• [x] fs.fstatSync
• [x] fs.fsync
• [x] fs.fsyncSync
• [x] fs.ftruncate
• [x] fs.ftruncateSync
• [x] fs.futimes
• [x] fs.futimesSync

[F3n67u]

may i work on this issue?

[bartlomieju]

@F3n67u yes, please do

[AliBasicCoder]

may i work on this issue?

please reference this issue in any PRs you're gonna create

[F3n67u]

may i work on this issue?

please reference this issue in any PRs you're gonna create

@AliBasicCoder ok, I will

[F3n67u]

@AliBasicCoder I tried to implement fs.opendir and fs.opendirSync, but looks like these methods are missing from deno fs api. @majidsajadi also mention this problem at https://github.com/denoland/deno_std/issues/802. I need to open issue at deno repo about the api Deno.opendir missing before I can implement the node counterpart, right?

[kt3k]

I'll work on fs.access https://nodejs.org/api/fs.html#fsaccesspath-mode-callback

[talentlessguy]

Implementing createReadStream would be awesome :pray:

(I'm rewriting a port of a Node.js framework and I need this func for readFile func)

[iuioiua]

I believe the following are required from the Deno FS API to be implemented:

• [ ] fs.lchmod
• [ ] fs.lchmodSync
• [ ] fs.lutimes
• [ ] fs.lutimesSync
• [ ] fs.readv
• [ ] fs.readvSync

Is this correct?

[kt3k]

I guess the last 2 could be polyfilled if we don't mind the performance