Yang Liu

Results 155 comments of Yang Liu

Do you have the steam version (with Goldberg emulator)? Are you able to test it? I don’t own this game on gog.

Yeah, I have a tg account. Please send me an email.

Confirmed, the issue of Factorio is unique to the Steam version, the official site full version works just like the demo version.

Try to use `BOX64_DYNAREC_TEST=1 box64 ./test27` on your local machine to see if there is any `DIFF xxx` logs.

So, the diffs are what you need to look into and fix..

> I did a quick check on an AMD machine and I think these are related to AMD as well, like #6411 and #2267. > > For the signal.* failures...

This is because 0xc5f957 is not a valid V instruction. Refer to riscv-v-spec Section 3.4.2, vlmul[2:0] = 0b100 is reserved.

@rui314 do we have any plan to implement this feature? If so, I can give it a try, seems straightforward. Related to https://github.com/llvm/llvm-project/issues/41353

> I can send all the related .so / .a ? You could use `--repro` to generate a reproducible .tar file, and upload it here.

Should we put the barrier on the `lookuptable` instead of the mask? e.g. for AArch64: ``` # emit_indirect_branch_lookup ldr xx, [x28, hash_mask] ldar xx, [x28, hash_table] # update_lookuptable_tls stlr xx,...