Yang Liu

Results 155 comments of Yang Liu

Feel free to ping me on tg if you need any help :)

Still, feel free to ping me for help 😄

This is supposed to the opportunity for @ricoazzurro to learn git, and you took it away! (I'm kidding)

Maybe add `BOX64_DYNAREC_MISSING=1` too, this will print out all the unimplemented opcodes, which might be the slowness came from.

Yes, remove the guards should be enough for CMake to build the test, then add the test name into [suite/tests/CMakeLists.txt#L6152](https://github.com/DynamoRIO/dynamorio/blob/master/suite/tests/CMakeLists.txt#L6152) and run `ctest -L RUNS_ON_QEMU` see if the test passes.

I suppose you’re referring to XINST_CREATE_cmp() and XINST_CREATE_jmp_cond? There won’t be such thing on RISC-V since we don’t have eflags. You can use INSTR_CREATE_beq() to rewrite this part for RISC-V.

Please don't do force push, see: https://dynamorio.org/page_code_reviews.html.

We're using some unstable API, so it changes from time to time, please check [build-and-test.yml](https://github.com/ksco/riscv-vector-tests/blob/main/.github/workflows/build-and-test.yml#L47) file to use a specific version of spike.