Kris West

Results 492 comments of Kris West

@julianna-ciq this didn't work, apparently PRs run in the context of the receiving repository (which is why giving them write access is dangerous), so the value of `github.repository` is always...

> If however `AppA` has an AppD record and the record states that the app listens for `StartCall` intents with the context `fdc3.contact` then the app should not be considered...

Thanks for reviewing @julianna-ciq, did you have a chance to test? If so, feel free to hit merge - otherwise let me know and I'll give it a go

@Yannick-Malins lemme know if you can make these two quick changes (I didn't add suggestions or I won't be able to review the change after you merge them) - alternatively...

Todo: - [x] the filename and this $id need to match in fileAttachment.schema.json - [x] define message entities with `oneOf` rather than `anyOf` in message.schema.json - [x] add a changelog

Thanks @Yannick-Malins. I'm not seeing the new type in the preview - but that could be because the PR is '199 commits behind finos/FDC3:main'. Could you merge changes from main...

LGTM, thanks @Yannick-Malins Docs page: https://deploy-preview-1261--fdc3.netlify.app/docs/next/context/ref/FileAttachment Page that links to new docs page: https://deploy-preview-1261--fdc3.netlify.app/docs/next/context/ref/Message ![image](https://github.com/user-attachments/assets/99ff14a0-d44f-44be-9ced-f9cc05cdd5ff)

The answer to this is not explicitly stated in the standard to my knowledge (it should be!). However, it consistently says that `addContextListener` _adds_ a listener - overwriting or replacing...