FDC3 icon indicating copy to clipboard operation
FDC3 copied to clipboard

1255 Make fdc3.fileAttachment an independent type

Open Yannick-Malins opened this issue 1 year ago • 7 comments

https://github.com/finos/FDC3/issues/1255

Yannick-Malins avatar Jul 15 '24 09:07 Yannick-Malins

Deploy Preview for fdc3 ready!

Name Link
Latest commit 92ecb7af53eaf50f2bbac797ab49eededc7a6477
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/670f678646cd4d0008e25ca9
Deploy Preview https://deploy-preview-1261--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 15 '24 09:07 netlify[bot]

@kriswest

Yannick-Malins avatar Jul 15 '24 09:07 Yannick-Malins

@Yannick-Malins lemme know if you can make these two quick changes (I didn't add suggestions or I won't be able to review the change after you merge them) - alternatively let me know to re-raise this PR and have you review instead.

kriswest avatar Sep 18 '24 13:09 kriswest

Todo:

  • [x] the filename and this $id need to match in fileAttachment.schema.json
  • [x] define message entities with oneOf rather than anyOf in message.schema.json
  • [x] add a changelog

kriswest avatar Oct 09 '24 11:10 kriswest

Thanks @Yannick-Malins. I'm not seeing the new type in the preview - but that could be because the PR is '199 commits behind finos/FDC3:main'. Could you merge changes from main then run npm run build. That should re-generate ContextTypes.ts so that goes in and the preview should generate correctly afterwards (those two are unrelated but we need to check both).

Otherwise looks all good to me. I'll get around to adding a PR template soon so the above steps are documented!

kriswest avatar Oct 14 '24 17:10 kriswest

should be good now!

Yannick-Malins avatar Oct 16 '24 07:10 Yannick-Malins

LGTM, thanks @Yannick-Malins

Docs page: https://deploy-preview-1261--fdc3.netlify.app/docs/next/context/ref/FileAttachment

Page that links to new docs page: https://deploy-preview-1261--fdc3.netlify.app/docs/next/context/ref/Message image

kriswest avatar Oct 16 '24 08:10 kriswest