Kris West

Results 489 comments of Kris West

@TheJuanAndOnly99 one more issue we spotted in an important schema (instrument): - New: https://issue-1068--exquisite-otter-12d363.netlify.app/docs/context/schemas/Instrument - Old: https://fdc3.finos.org/docs/next/context/ref/Instrument First, ignore the difference in the description - I moved the notes into...

> @kriswest - we did that, but since then all my commits fail with `/Users/m/w/FDC3/src/internal/typeHelpers.ts - Parsing error: Cannot read properties of undefined (reading 'map')` ; was there any change...

I can replicate. Its from the linter, which is setup to lint src on commit, where the lint command only does src/api. Not exactly sure what its problem is however...

@maoo see https://github.com/finos/FDC3/pull/1187 for a solution (needs review and merge)

...and you might need to delete package-lock.json

Is this ready for re-review @maoo and @TheJuanAndOnly99 ? Its still marked draft so just checking. If its ready I can encourage the @finos/fdc3-maintainers and @finos/fdc3-editors to review and merge

@TheJuanAndOnly99 schema2markdown is tripping one of the semgrep rules: https://github.com/finos/FDC3/actions/runs/8837630351/job/24266920820?pr=1151 and the build failed, probably indicating that you need to run npm install in your branch (possibly also delete the...

@TheJuanAndOnly99 I've manually re-run it. I know its going to fail (as the docusaurus website has developed an issue with a dependency, but the log will tell us whether anything...

@TheJuanAndOnly99 you're all clear! Just he axios dependency issue in the log

@mistryvinay and I should be able to take it from here - we need to run through another review and then make the tweaks necessary to have the generated pages...