Kris West

Results 489 comments of Kris West

Do you want to _support_ the use of the defined values (i.e. give intellisense, but allow any string) or should we constrain the type/schema to a specific enum? Either is...

@robmoffat mentioned that there are a set of classifications for instruments as part of the CDM project. it would would be worth researching those before finalising a list.

Without an external standard to reference for the values, we could either go with 'fdc3' or we can acknowledge this is your list and use something like `FDS` (we have...

I'm not thinking about the categories these additions show up in, but then the default view is a single list with everything, alpha sorted. That will place two entries next...

Apologies, I haven't had time to circle around to a number of action items as yet. The minutes for the maintainers meeting that covered it are in the fdc3-maintainers channel....

@nkolba apologies for the delay - I'll try and set aside an hour at the end of the day today or tomorrow to take a look at the categories again...

I sent a note about this PR on #1169 some time ago - it needs updating if you want to get it merged, otherwise there's nothing blocking it.

I'm going to go ahead and merge this into a FINOS repo branch to make it easier for a few us to work on it. That'll reset the comments, which...

> Can you give me a clear mapping between the schema and the typescript (and c#) files to point to? @TheJuanAndOnly99 The mapping from schema to typescript is easy because...

@TheJuanAndOnly99 merging changes from upstream:master/main and re-running npm install will probably resolve the issues with the checks you're having above. This should sort out your fork: ``` git fetch git...