Kris Wallsmith comments

Results 28 comments of


                                            Kris Wallsmith

Check leaves for changes before dumping

This makes sense in the watch command, but I'm not comfortable adding this to the dump command without an option to force a fresh dump of everything.

Added feature to overwrite JS/CSS of Bundles in app/Resources (like Twig-Templates overwrite mechanism)

This is a big patch. Do I understand correctly that you want to be able to replace partials called from inside a third party SASS file?

Make AsseticBundle works with AssetCache

Hi @scourgen, Thanks for the pull request. At first glance this change adds a layer of complexity that doesn't appear to be worth it. Why do you think this should...

make it possible to generate cache manifest

I think this should be its own command.

Fix relative url rewrite with same parent directory.

Please add a test case. `CssRewriteFilter` is so tricky I can't merge anything in without a test case.

combine=false in twig ignored

Hm, Assetic should always respect `combine` — it is more specific than `debug`.

combine=false in twig ignored

@stof The command in the bundle looks flawed. The `combine` value should be available in the formula there.

TypeScriptFilter now uses actual file instead of temp (if it exists)

There's an example of how we do this here: https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Filter/LessFilter.php#L92 Can you configure TypeScript load paths in a similar way?

TypeScriptFilter now uses actual file instead of temp (if it exists)

I'd rather not have the `$this->useOut` switch. We should determine the best way to use TypeScript and do it the same way every time.

Less variables not imported globaly

I'm not sure how this is happening. Are you running both the Sass and CssEmbed filters?