assetic-bundle icon indicating copy to clipboard operation
assetic-bundle copied to clipboard

Published 20 hours ago • verified publisher icon symfony

Check leaves for changes before dumping

Open artursvonda opened this issue 10 years ago • 11 comments

artursvonda avatar Sep 25 '13 08:09 artursvonda

This makes sense in the watch command, but I'm not comfortable adding this to the dump command without an option to force a fresh dump of everything.

kriswallsmith avatar Sep 25 '13 17:09 kriswallsmith

When using with regular dump command, $previous will be empty and thus will dump all the files. I left it there for consistency.

artursvonda avatar Sep 26 '13 08:09 artursvonda

any news on this?

nicam avatar Oct 24 '13 07:10 nicam

I really want this. My SASS compiling is soooo slow because everything has to be rendered again every time.

ruudk avatar Nov 28 '13 10:11 ruudk

@kriswallsmith any feedback or are we good to merge this?

artursvonda avatar Dec 01 '13 11:12 artursvonda

Bump comment. What's holding back this PR?

artursvonda avatar Feb 12 '14 10:02 artursvonda

I think this is the follwer of https://github.com/symfony/AsseticBundle/pull/233

Will there be any progress on this?

robertfausk avatar Aug 06 '15 10:08 robertfausk

I rebased my PR. There are some failures in tests, but looks like they are because dev-master version of some of the symfony components where used (meaning, Symfony 3.0 components). Not sure, where the bug is, but it's not bundle's fault. Everything works if dependencies are installed with '--prefer-stable'.

artursvonda avatar Aug 06 '15 11:08 artursvonda

@artursvonda Can't you simply remove the minimum-stability setting from the composer.json file?

xabbuh avatar Aug 07 '15 22:08 xabbuh

@artursvonda ping:)

robertfausk avatar Sep 10 '15 13:09 robertfausk

The issue is not on my end and I'm not sure if the issue is with Symfony component versioning or composer. The composer.json file looks correct.

artursvonda avatar Sep 10 '15 13:09 artursvonda