Petr Kraus

Tweak the basic subpass dependencies

5

fix #665

Misleading example base subpass dependencies?

10

``` dependencies[0].srcSubpass = VK_SUBPASS_EXTERNAL; dependencies[0].dstSubpass = 0; dependencies[0].srcStageMask = VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT; dependencies[0].dstStageMask = VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT; dependencies[0].srcAccessMask = VK_ACCESS_MEMORY_READ_BIT; dependencies[0].dstAccessMask = VK_ACCESS_COLOR_ATTACHMENT_READ_BIT | VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT; dependencies[0].dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT; ``` Not entirelly sure why exacly...

Why is `gl_SubgroupSize` not a constant?

19

Why is `gl_SubgroupSize` not a constant? Per Vulkan spec it is PhysicalDevice property, so it feels it could be a built-in constant. Currently it seems to be listed under built-in...

Using tabs for alignment

8

I have seen code here which uses tabs for code alignment (not just indenting), e.g. https://github.com/KhronosGroup/VK-GL-CTS/blob/master/external/vulkancts/modules/vulkan/wsi/vktWsiSwapchainTests.cpp AFAIK that is the incorrect usage of tabs. It assumes tab is always 4...

Fix some warnings

2

- `settingsDialog` and `submitDialog` does not use `f`; should call a super with it? - `parentItem` is shadowed -> just enclose sparse props into block - `widget` name is twice...

Fix and update VkFormat support

1

- fix format VK_FORMAT_G16_B16_R16_3PLANE_444_UNORM - #24: support VK_IMG_format_pvrtc formats - support VK_EXT_texture_compression_astc_hdr formats not sure how report json and upload works yet though, so not sure if this is sufficient.

- use unix endlines - use tabs - remove some trailing whitespace I recommend checking this in GitHub:  It should show this is virtually nill diff.

Ideas for future formatting improvements (exported from #82): - show large numbers with a thousands separator - show large byte values in Ki, Mi, Gi - show large hex values...

Add support for VK_EXT_tooling_info

3

output might be bit misleading as it would lack the tools from Validation Layers if not enabled. For the most part probably will be empty unless the driver feels like...

Format tree cannot be expanded when searching

1

The Format tree cannot be expanded when searching a format. When some filter is entered, everything collapses, and the expansion arrow next to formats dissapear.