Kevin Reid comments

Results 381 comments of


                                            Kevin Reid

Consider a custom type for easier size hints

I'm working on this now.

trycmd: Document `fs.sandbox` and working directory behavior

> We don't specify the default outside of that condition I mean to claim that it should be at least documented as unspecified, for clarity. > I beleive it should...

cargo-audit fails to fetch advisory database: "Could initialize the http client"

> @kpreid could you please try #1053 and post the error it produced? It should be more informative this time around. No change! ``` $ git rev-parse HEAD f23756e35353e045fbe1b316afae26cc72620e4c $...

cargo-audit fails to fetch advisory database: "Could initialize the http client"

The error being printed here is a `rustsec::error::Error` which never reports any `source()`; it contains only a `String`. Therefore, the place actually needing formatting is: https://github.com/rustsec/rustsec/blob/f23756e35353e045fbe1b316afae26cc72620e4c/rustsec/src/repository/git/repository.rs#L291 Patching that, ```rust .map_err(|err|...

cargo-audit fails to fetch advisory database: "Could initialize the http client"

`rustsec::format_err!` (a public macro) is expanding to a use of `crate::error::Error::new()` (i.e the macro caller's crate) not `$crate::error::Error::new()` (the `rustsec` crate). This seems to be used intentionally, but that's a...

cargo-audit fails to fetch advisory database: "Could initialize the http client"

> Is that macro really public? No, it isn't. My mistake; when constructing my understanding of the situation I mixed up `#[macro_use]` with `#[macro_export]`, and was misled about its usage...

cargo-audit fails to fetch advisory database: "Could initialize the http client"

> I think we'll need to rework (and semver-break) the `rustsec::Error` type and likely ditch or rework `format_err!` too. … I don't think this work is necessarily a semver break;...

bump in struct

In order to borrow multiple fields at once you can use the generated [`.with_mut()`](https://docs.rs/ouroboros/0.18.3/ouroboros/attr.self_referencing.html#mystructwith_mutrself-user-fnoncefields-allfields---r---r) method. This will compile: ```rust pub fn symbol_new(&mut self, bs: &S) -> Symbol { let found...

Fix component reflection such as to not force the component to `impl Default`

I ran into this myself when [adding `ShowLabels`](https://github.com/rerun-io/rerun/pull/7249/). `ShowLabels` is a component whose fallback value [is _always_ computed from other data,](https://github.com/rerun-io/rerun/blob/6121840ba46528c727197bc71d826a5e9527e869/crates/viewer/re_space_view_spatial/src/visualizers/utilities/labels.rs#L85-L110) and does not have a default that is meaningful...

It is surprising / undocumented that some functions can panic due to validation errors

You can use [error scopes](https://docs.rs/wgpu/latest/wgpu/struct.Device.html#method.push_error_scope) to capture errors from specific operations rather than all operations. (Unfortunately, that's global state so it doesn't play well with using a device from multiple...