Kevin Reid
Kevin Reid
Whoops, the design of `PositiveSign` is not consistent. In FP arithmetic, `0.0 * INFINITY` is NaN, so as long as `PositiveSign` includes `INFINITY`, it isn’t closed under multiplication. My first...
Implemented `0.0 * INFINITY == 0.0` in b24f917f923bf488685ae1c1d1de46b1454b22bf.
`Aab` is not using `NotNan` but it enforces its own `lower ≤ upper` restriction, and has no consideration of negative zero, so it needs work like the other types here.
Commit eefacde9a23fd384445c40c6cfaed097b7ac470b *adds* `NotNan` to `Body` position and velocity. It’s not the right type; besides signed zero issues, this use case kind of wants to prohibit infinities too. However, it...
It's plausible that there is also code not *within* an unsafe block which is still important for soundness (if the code follows the principle of keeping unsafe blocks narrowly scoped...
I think the right thing to do here is to have `indicatif` hooked up to the notification hub like the VUI progress bar is, so that the “application” code isn’t...
As someone interested in the 2.0 plan, and with an application that exports to glTF, I tried out this branch, and here are my observations: * `gltf::buffer::View` is serialized with...
> converting these to a type alias instead and perhaps having the type configurable. Changing a type alias would be a [non-additive](https://doc.rust-lang.org/cargo/reference/features.html?highlight=additive#feature-unification) feature (regardless of the direction it goes; both...
> I do think it is important we have a way of maintaining semver though. I'm leaning towards feature gating all additional members. We had this before but I removed...
I notice that in the current state of the branch (9b8bc87d4fc096594baa17661b17f35f85e475eb), `gltf` doesn't compile unless `features = ["import"]` is enabled. It looks like this is because the `#[cfg(feature = "import")]`...