Kevin Reid
Kevin Reid
@teoxoy I think you misunderstand. I'm saying that, according to the WebGPU specification, calling `requestDevice()` more than once on a given `Adapter` value **should return an error**. An `Adapter` value...
Note: I see the lint check is failing: ``` /home/runner/work/rerun/rerun/crates/store/re_types/src/components/fill_mode.rs:58: Found double space /home/runner/work/rerun/rerun/crates/store/re_types/src/components/fill_mode.rs:61: Found double space ``` * This is a _generated file_ — should it really be linting...
As of be82f4d441cf5d9e133831906b2191fa923c7116, `BlockAttributes` has a lot of its structure generated via macros. I was hoping that this would enable macro-generated `Modifier` variants to set attributes. However, doing this in...
This turns out to require rethinking of how *all* modifiers interact with operations. As I wrote in 21320943d8edb872f676e23149b8998b7555a073 which adds some inactive code that would try to implement compositing operations:...
Another example of “case 1” being the right choice: suppose a block with a `Become` operation has a `Modifier::Inventory` — surely the inventory should not be destroyed by default, so...
Commit d5b7ce7ae713c9d04a77bd82583274dcd315a5b9 switches over to “case 1” for `Move` and `Composite`. * Relevant ignored tests have been enabled. * This enabled e8c6cfb5dd0abd9c49f41cdcc7a4cc31be857acc, unlockable doors in the dungeon. However, the original...
Commit 20cd9d6bef132120a70e0b9a92e945aa98fb24b1 replaces all uses of `NotNan` within color types with the new numeric wrapper `PositiveSign`. Next steps: * There's a lot of places where what is needed is a...
As of commit ef1a45e9e030a8c03a23541c67e8e4687ecf7c09, there is a `ZeroOne` type, and it is used by `Rgba` for alpha and `GraphicsOptions` for bloom blending.
As of commit 30ceaed2035745b3dbbec06b13f70c9cbff85e01, `GraphicsOptions` no longer uses `NotNan`.
Remaining non-incidental uses of `NotNan`: * Points/vectors (can't be `PositiveSign` since they can be negative): * `Spawn::eye_position` * `Spawn::look_direction` * `SpacePhysics::gravity` * `Fluff::BlockImpact::velocity` (can be `PositiveSign`) (update: done in commit...