rerun
rerun copied to clipboard
Add `FillMode::MajorWireframe` for more significant ellipsoid wireframes.
What
- Add
FillMode::MajorWireframe. For ellipsoids, this causes them to be drawn as three axis-aligned ellipses. It has no other effects. This implements the main part of #6962. - The previous
FillMode::Wireframehas also been been renamed toDenseWireframeto reflect its relative role. - Updated
hexasphereto 14.1.0 and removed the bug workaround code.
I'm not sure if adding another FillMode is the best way to expose this rendering functionality, but it works out tidily enough for now.
This does not modify any examples, but if we applied MajorWireframe to the ellipsoid3d_batch snippet, we'd get:
Checklist
- [X] I have read and agree to Contributor Guide and the Code of Conduct
- [X] I've included a screenshot or gif (if applicable)
- [ ] I have tested the web demo (if applicable):
- Using examples from latest
mainbuild: rerun.io/viewer - Using full set of examples from
nightlybuild: rerun.io/viewer
- Using examples from latest
- [X] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
- [X] If applicable, add a new check to the release checklist!
- [X] If have noted any breaking changes to the log API in
CHANGELOG.mdand the migration guide
To run all checks from main, comment on the PR with @rerun-bot full-check.
Note: I see the lint check is failing:
/home/runner/work/rerun/rerun/crates/store/re_types/src/components/fill_mode.rs:58: Found double space
/home/runner/work/rerun/rerun/crates/store/re_types/src/components/fill_mode.rs:61: Found double space
- This is a generated file — should it really be linting those?
- The specific double spaces I presume it is complaining about are a part of Markdown bullet list formatting, so they should not be removed.