rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Add `FillMode::MajorWireframe` for more significant ellipsoid wireframes.

Open kpreid opened this issue 1 year ago • 1 comments

What

  • Add FillMode::MajorWireframe. For ellipsoids, this causes them to be drawn as three axis-aligned ellipses. It has no other effects. This implements the main part of #6962.
  • The previous FillMode::Wireframe has also been been renamed to DenseWireframe to reflect its relative role.
  • Updated hexasphere to 14.1.0 and removed the bug workaround code.

I'm not sure if adding another FillMode is the best way to expose this rendering functionality, but it works out tidily enough for now.

This does not modify any examples, but if we applied MajorWireframe to the ellipsoid3d_batch snippet, we'd get:

Screenshot 2024-08-02 at 14 23 09

Checklist

  • [X] I have read and agree to Contributor Guide and the Code of Conduct
  • [X] I've included a screenshot or gif (if applicable)
  • [ ] I have tested the web demo (if applicable):
  • [X] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • [X] If applicable, add a new check to the release checklist!
  • [X] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

kpreid avatar Aug 02 '24 21:08 kpreid

Note: I see the lint check is failing:

/home/runner/work/rerun/rerun/crates/store/re_types/src/components/fill_mode.rs:58: Found double space
/home/runner/work/rerun/rerun/crates/store/re_types/src/components/fill_mode.rs:61: Found double space
  • This is a generated file — should it really be linting those?
  • The specific double spaces I presume it is complaining about are a part of Markdown bullet list formatting, so they should not be removed.

kpreid avatar Aug 10 '24 04:08 kpreid