knottnt

Results 23 comments of knottnt

@michaelhtm I believe similar work was done in #564. Can this PR be closed?

/hold Adding hold for unit tests. Assuming there is a AWS service that requires these changes for a CRD to be generated correctly. Should add it to test data with...

Looks like the ServiceRegion is currently listed under the [ignored fields paths](https://github.com/aws-controllers-k8s/ec2-controller/blob/b3570a72f8a4fe236c4e7d2d7614928526982812/generator.yaml#L65). Will need to remove it from that list to include it in the VPC Endpoint CRD.

@farhaan-shamsee Does the VPC Endpoint Service you're trying to connect to have `Supported Regions` set to include ap-southeast-1? If the VPC Endpoint Services are also managed by ACK it looks...

Hmm testing adding the `serviceRegion` field on my end and I'm able to create a new VpcEndpoint connecting from `ap-southeast-1` to a VPC Endpoint Service in `eu-central-1` with the below...

@farhaan-shamsee support for service region on VPC Endpoints has been released in v1.6.0.