knottnt

Results 29 comments of knottnt

/close Haven't needed this feature for a number of years and have partially implemented with [SkipIncompleteLateInitization](https://github.com/aws-controllers-k8s/code-generator/pull/606) flags. Will re-open or create new issue if needed.

> Hey @knottnt > > Thanks for the feedback! Just to clarify, this change removes the default CPU limit from `values.yaml`, but users can still explicitly set `resources.limits.cpu` in their...

@macneib: Also any changes to the helm chart should be done in the code-generator repo's [Helm templates](https://github.com/aws-controllers-k8s/code-generator/tree/main/templates/helm). We use those files to keep our Helm charts consistent across all ACK...

@alexcristi: It looks like there's some compilation issues with these changes. Any chance there's some un-pushed commits? ``` 32.93 pkg/resource/managed_prefix_list/sdk.go:179:23: invalid operation: elem.State != nil (mismatched types "github.com/aws/aws-sdk-go-v2/service/ec2/types".PrefixListState and untyped...

> @knottnt - Also, what do you want me to do with `ec2-verify-code-gen`? Do you want me to rebuild with `v0.19.0`? If I do so, are we okay with committing...

> @knottnt, I am bit confused to what's going on with the `ec2-verify-code-gen` check; I generated with both `v0.16.2` and `v0.19.0`, yet the check complains about the same diffs in...

@jwilms1971 It looks like support for setting DatabaseInsightsMode needs to be added to the controller. The field is currently being ignored in the [generator.yaml](https://github.com/aws-controllers-k8s/rds-controller/blob/26eb032a0a75c034c816032f05e4069729595419/generator.yaml#L27).

@jwilms1971 v1.6.0 of the rds-controller add support for setting the DatabaseInsightsMode field.