s3-controller icon indicating copy to clipboard operation
s3-controller copied to clipboard

Feature - Directory Bucket Support (S3 Express)

Open Itai-Melamed opened this issue 1 month ago • 6 comments

Issue #2658

Description of changes: Implemented support for DirectoryBuckets Creation by removing ignore of DirectoryBucket Fields.

  • CreateBucketConfiguration.Bucket
  • CreateBucketConfiguration.Location

Overrided some of the operations that don't support directory buckets with the equivalent S3 Express operations. (in - pkg/resource/bucket/hook.go)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Itai-Melamed avatar Oct 23 '25 09:10 Itai-Melamed

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Itai-Melamed Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Oct 23 '25 09:10 ack-prow[bot]

Hi @Itai-Melamed. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Oct 23 '25 10:10 ack-prow[bot]

/ok-to-test

knottnt avatar Oct 23 '25 16:10 knottnt

/test s3-kind-e2e

knottnt avatar Oct 23 '25 17:10 knottnt

/retest

Itai-Melamed avatar Oct 29 '25 15:10 Itai-Melamed

@Itai-Melamed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-kind-e2e 0ba503e9860b84814b804d65285858b842757df9 link true /test s3-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Oct 30 '25 17:10 ack-prow[bot]