kitsuyui

Results 7 comments of kitsuyui

Similar issue is here: https://github.com/dotnet/core/issues/3598

すみません、こちらの内容もだいぶ時間が経ってしまっていますね。 2 年前はまだ data_source_adapters などがない前提で書いているので、 app/models/data_source.rb 中で SQL Server 用のコードと PostgreSQL 用のコードに分岐していて、非常に見通しが悪いです。 後日、改めてプルリクエストを出し直させていただきます 🙏

@hogelog Thank you! I'll solve that you pointed out.

@hogelog I have tried to write RSpec for testing top page. Is this RSpec style OK? If its direction is OK, I can write more for filling coverage.

@hogelog I'm sorry to have kept you waiting. I've updated the rspec and rebased these commits. Would you please review this? (CI Hakiri shows warning because of Nokogiri v1.10.3 (CVE-2019-11068)....

I have already forked to https://github.com/kitsuyui/discord-vc-notification and will try to create a Pull Request if I have the time.

Sorry, I didn't notice until I posted this Issue. It was enough to have `qemu-user-static` installed. If `qemu-user-static` is installed, Docker can run an image of linux/amd64 on a host...