dmemo icon indicating copy to clipboard operation
dmemo copied to clipboard
verified publisher icon cookpad

Browsing without login by setting environment variable

Open kitsuyui opened this issue 8 years ago • 4 comments

  • Enable readonly browsing when DMEMO_ALLOW_ANONYMOUS_TO_READ is set
  • https://github.com/hogelog/dmemo/issues/92

kitsuyui avatar Dec 09 '17 05:12 kitsuyui

@hogelog Thank you! I'll solve that you pointed out.

kitsuyui avatar Dec 12 '17 02:12 kitsuyui

@hogelog I have tried to write RSpec for testing top page. Is this RSpec style OK? If its direction is OK, I can write more for filling coverage.

kitsuyui avatar Dec 30 '17 10:12 kitsuyui

Sorry too late response.

Please use context like http://www.betterspecs.org/#contexts and other specs.f

hogelog avatar Feb 16 '18 02:02 hogelog

@hogelog

I'm sorry to have kept you waiting.

I've updated the rspec and rebased these commits. Would you please review this?

(CI Hakiri shows warning because of Nokogiri v1.10.3 (CVE-2019-11068). But it should be solved in another pull-request, I think.)

kitsuyui avatar May 06 '19 09:05 kitsuyui