Chris S. Kim
Chris S. Kim
> @kisunji I haven't had one of these failed-backport PRs before! 😅 I think I've done the right thing by pushing a fix to this branch? I've been seeing this...
Thank you everyone for the reports. We narrowed down the issue to a breaking change that has been addressed in [1.13.1](https://github.com/hashicorp/consul/releases/tag/v1.13.1). This bug in 1.13.0 affects those upgrading from Consul...
Hi @dekimsey, thanks for this PR! I'd like to request that your PR targets `main` - we generally do not add features to older releases (unless they are bugfixes or...
Thanks @dekimsey! Our team is busy with a some releases this week but will aim to have this reviewed early next week!
Would you be able to rebase from main? Looks like there's been several refactors since this PR was up. Let me know if anything gets complicated. No worries about taking...
Thanks @dekimsey! I'm going to sanity check that this won't break any files in Enterprise then will try to get another set of eyes for review.
Hi @dekimsey, Sorry for the delay in getting back to you. There are some tests on the enterprise side that need updating so I will work on it and have...
I suspect there are some internal RPC calls which expect to block indefinitely but are getting timed out and re-established. @seanamos 's log fragments could suggest that our cache layer...
Thank you @jameshartig for the investigation and quick fix 🕵️ It will be backported to the next patch versions of 1.12.5 and 1.13.2
That sounds reasonable. Would you mind making the requested changes and adding a testcase in agent/xds/listeners_test.go? Something like: ```go { name: "custom-trace-listener", create: func(t testinf.T) *proxycfg.ConfigSnapshot { return proxycfg.TestConfigSnapshot(t, func(ns...