Chris S. Kim comments

Results 36 comments of


                                            Chris S. Kim

Fix topoloy intention with mixed connect-native/normal services.

Hi @apollo13, I don't have the bandwidth to review at this time. If you could describe what the bug is that you are trying to fix (maybe replication steps if...

Bug: in Event drag:over:container is event.data.mirror undefined

It looks like they refactored MirrorEvent in `v1.0.0-beta.8`.

Add support for defining Vault address and token through environment variables in Consul Connect CA provider

The general convention is to have environment variables as higher priority over config files so it may be confusing if we decide to make the config address override the environment...

Add support for defining Vault address and token through environment variables in Consul Connect CA provider

Maybe we can shorten to `CONSUL_CA_VAULT_ADDR` and `CONSUL_CA_VAULT_TOKEN`? I'm in full support of this approach in any case!

Catalog Watch uses blocking queries incorrectly

A solution could be to make the default `catalogServicesWatchTimeout` -1 and only add timeout to the catalog request if the value is > 0.

Add information in Consul logs for Nomad service checks

Although a service has reference of its health checks, a check does not know about its service when these logs are emitted. It's not _impossible_ to pass the service ID...