consul icon indicating copy to clipboard operation
consul copied to clipboard

Backport of cli: update agent log preamble to reflect per-listener TLS config into release/1.12.x

Open hc-github-team-consul-core opened this issue 2 years ago • 2 comments

Backport

This PR is auto-generated from #14077 to be assessed for backporting due to the inclusion of the label backport/1.12.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Description

We made it possible to configure TLS per-listener in Consul 1.12 but never updated the agent log output to reflect this.

Now, each listener/protocol's TLS settings are listed separately for clarity.

==> Starting Consul agent...
              Version: '1.13.0-dev'
             Revision: 'e4a579022b+CHANGES'
           Build Date: '2022-08-09 10:08:07 +0000 UTC'
              Node ID: 'f650ac70-0d0d-ee41-17a1-35a4d06dcb31'
            Node name: 'daniel-macbook'
           Datacenter: 'dc1' (Segment: '<all>')
               Server: true (Bootstrap: false)
          Client Addr: [127.0.0.1] (HTTP: 8500, HTTPS: -1, gRPC: 8502, DNS: 8600)
         Cluster Addr: 127.0.0.1 (LAN: 8301, WAN: 8302)
    Gossip Encryption: false
     Auto-Encrypt-TLS: false
            HTTPS TLS: Verify Incoming: false, Verify Outgoing: false, Min Version: TLSv1_2
             gRPC TLS: Verify Incoming: false, Min Version: TLSv1_2
     Internal RPC TLS: Verify Incoming: false, Verify Outgoing: false (Verify Hostname: false), Min Version: TLSv1_2

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • [x] boxofrad
  • [ ] temp

temp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Aug 10 '22 09:08 hashicorp-cla

@kisunji I haven't had one of these failed-backport PRs before! 😅 I think I've done the right thing by pushing a fix to this branch?

boxofrad avatar Aug 10 '22 10:08 boxofrad

@kisunji I haven't had one of these failed-backport PRs before! 😅 I think I've done the right thing by pushing a fix to this branch?

I've been seeing this in 1.12 backports as well :/ you'll have to manually make a branch off release/1.12.x and cherrypick your commits. This PR can't be merged because of the CLA issue with the bot account

kisunji avatar Aug 10 '22 12:08 kisunji

This PR can't be merged because of the CLA issue with the bot account

I think that because we know the CLA violation is because of our bot account, it's not really a CLA violation. So, since the other checks are all passing, I'm going to save us the effort of creating a separate PR and just merge this.

eculver avatar Aug 10 '22 23:08 eculver