Bruno P. Kinoshita

Results 709 comments of Bruno P. Kinoshita

Hi @oceenachi ! >Don't know if I am replying late or I can still make the fixes. Please do let me know thanks We just released CWL Viewer, however, we...

Query from the Wiki (in case we decide to archive that page): https://github.com/common-workflow-language/cwlviewer/wiki/MongoDB-Queries ``` This is a page to design MongoDB queries for common-workflow-language/cwlviewer#117 Gets, where retrievedFrom.repoUrl and retrievedFrom.path are...

Tried to import this workflow on `localhost:8080`, with latest version from `main` (after changing `docker-compose.yml` to use `build: .`.) It failed running `cwltool` for me. But not sure if that's...

```bash (venv) kinow@ranma:~/Development/python/workspace/cwl_workflows/complex-workflow$ cwltool --version /home/kinow/Development/python/workspace/cwltool/venv/bin/cwltool 3.1.20220204090313 cwltool --validate complex-workflow-1.cwl # same error as local CWL Viewer ``` Would have to look at the logs in the server, and whether...

Confirmed that when the Workflow controller receives a request for a workflow in the format `/workflows/repo-url, it will call a service to parse the workflow file. ![image](https://user-images.githubusercontent.com/304786/160495969-eb2e030c-d7c6-45e5-9a61-b47bdd413eb3.png) When loading the...

Huh, funny. Was trying to get the workflow to pass validation in some old version of `cwltool`, but even 1.0x failed. ```bash (venv) kinow@ranma:~/Development/python/workspace/cwl_workflows$ cwltool complex-workflow/complex-workflow-1.cwl INFO /home/kinow/Development/python/workspace/cwltool/venv/bin/cwltool 1.0.20191225192155 INFO...

Looks like it was intentionally hidden on smaller viewports (CSS class `hidden-xs`). The verified link: https://github.com/common-workflow-language/cwlviewer/blob/492770e7aed67722d35959e05b0fa0a058fbb17f/src/main/resources/templates/workflow.html#L144-L146 And the permalink: https://github.com/common-workflow-language/cwlviewer/blob/492770e7aed67722d35959e05b0fa0a058fbb17f/src/main/resources/templates/workflow.html#L154-L159

That would make more sense, the smaller icon. I think the verified icon could also be displayed although it is useful to know the cwltool version as well.

Great idea! I think the only counter-argument for something like this is trying to prevent an attacker from knowing exactly what's the version deployed (I think GitLab does that, it...

Hi, the URL provided, https://gitlab.inria.fr/capsid.public_codes/CroMaSt/-/blob/main/CroMaSt.cwl, does not pass the current regex tests in the JavaScript code https://github.com/common-workflow-language/cwlviewer/blob/3088d53f425f5a6cb922228b57e1b6f7671820a2/src/main/resources/static/js/main.js#L80-L98. There are two regular expressions, one for GitHub, and for for GitLab. Respectively:...