cwlviewer icon indicating copy to clipboard operation
cwlviewer copied to clipboard

permalink not visible on small screens

Open mr-c opened this issue 3 years ago • 3 comments

Example https://view.commonwl.org/workflows/github.com/BD2KGenomics/dockstore_workflow_fusion/blob/master/fusion_workflow.cwl

Neither in mobile view, portrait mode

Screenshot_20221230-102402

Horizontal mode Screenshot_20221230-102411

Nor desktop mode Screenshot_20221230-102432

mr-c avatar Dec 30 '22 09:12 mr-c

Looks like it was intentionally hidden on smaller viewports (CSS class hidden-xs).

The verified link: https://github.com/common-workflow-language/cwlviewer/blob/492770e7aed67722d35959e05b0fa0a058fbb17f/src/main/resources/templates/workflow.html#L144-L146

And the permalink: https://github.com/common-workflow-language/cwlviewer/blob/492770e7aed67722d35959e05b0fa0a058fbb17f/src/main/resources/templates/workflow.html#L154-L159

kinow avatar Dec 30 '22 09:12 kinow

Thanks for the quick sleuthing @kinow !

I think permalinks are pretty important, though I can see how they could screw up the layout. Maybe the intention was to just display an icon for small displays instead of the full URL?

mr-c avatar Dec 30 '22 09:12 mr-c

That would make more sense, the smaller icon. I think the verified icon could also be displayed although it is useful to know the cwltool version as well.

kinow avatar Dec 30 '22 10:12 kinow