Bruno P. Kinoshita
Bruno P. Kinoshita
Fixed one broken test today, three more to go. Two I know the reason, but not the solution. The other we had during the migration mongo->postgres, so I just need...
The last test failing is due to Hibernate/Postgres. At least the others were fixed (at least locally, waiting for GH Actions). Time to search for issues/SO's/etc now :grimacing:
Finally had some time to give it another try, and managed to get all tests passing. Still a couple of points pending, and I will try to do some manual...
> @kinow Shall I merge? Let me rebase, and then do some quick tests with Docker locally. Then it should be ready to go! :boom:
@mr-c rebased, GH Actions passed, then checked out latest commit, ran `docker compose up`, uploaded some CWL files, they were all correctly rendered. I think it's ready to be merged...
See comments in the linked issue in jena, e.g. >> Not sure if CWLViewer is using Jena 4 and 3 at the same time. > >Jena uses ServiceLoader to initialize...
Created this issue as I don't think these will be addressed immediately in #226 :+1:
> @kinow are these now covered? It looks like the first one is at least. https://www.commonwl.org/user_guide/faq.html#use-cwl-and-cwltool-with-singularity Ah, good catch. Yes, that's covered. But that was the only task of this...
I think this has been fixed already, @manabuishii ? Or is there anything pending so that this issue can be closed? Thanks!
Note: to find out where an old numbered section went, check the `src/conf.py` file :+1: e.g. https://github.com/common-workflow-language/user_guide/blob/3ed85b81ecc6a16a3b91f4b8f822774cc3212faf/src/conf.py#L116