#172 error messages should state version of cwltool being used

[oceenachi]

Description

Following #172, when there is an error in parsing a given workflow it is expected that the version of cwl tool used in parsing that workflow is returned in the error body. I also removed a portion of redundant code versionhere in loading.html

Motivation and Context

The change is required because it fixes the problem of cwltoolVersion not being shown when there is a parsing error as described in #172

#172

How Has This Been Tested?

Firstly I made sure I reproduced the error as shown on #172. After making changes, I started up my local environment and tried to parse the same URL as used in reproducing the error. Then I looked for changes in the error body. The difference is shown in the before vs after images below

Screenshots (if appropriate):

Previous image

After code change

Types of changes

• [ X] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[oceenachi]

Okay will do so

[oceenachi]

Hey @mr-c, I'm struggling with how to go about writing the test. First of all, I don't know if the test should be on WorkflowService which is the class I made the fix on or the Workflow controller which sends the version to loading.html.

I tried creating the test on workflow service to verify that the version is set when the retryCwltool() is called, but retryCwltool returns void so I can't test that the value of cwltoolVersion changes.

Can you help me with ideas of how I can go about this?

Thanks

[kinow]

Ping @oceenachi

We are cutting a release soon, but with another one to come in the next weeks/months. Keen to include this one if you have time to reply on the latest feedback :+1:

Thanks!

[oceenachi]

Ping @oceenachi

We are cutting a release soon, but with another one to come in the next weeks/months. Keen to include this one if you have time to reply on the latest feedback 👍

Thanks!

Hi @kinow,

Don't know if I am replying late or I can still make the fixes. Please do let me know thanks

[kinow]

Hi @oceenachi !

Don't know if I am replying late or I can still make the fixes. Please do let me know thanks

We just released CWL Viewer, however, we already have more changes lined up for the next release! So anytime you can make the fixes for this PR, we should be able to review in a few days (holidays season is on us after all :christmas_tree: ) and include it in one of the next releases.

Thanks! -Bruno