user_guide icon indicating copy to clipboard operation
user_guide copied to clipboard

No outputs at lesson 23

Open manabuishii opened this issue 6 years ago • 4 comments

In lesson 23 There are 3 cwl files. But every cwl files have just outputs: []

Rabix Composer can not execute these cwl correctly.

It shoud have something.

For examle.

scatter-workflow.cwl

#!/usr/bin/env cwl-runner

cwlVersion: v1.0
class: Workflow

requirements:
  ScatterFeatureRequirement: {}

inputs:
  message_array: string[] 

steps:
  echo:
    run: 1st-tool.cwl
    scatter: message
    in:
      message: message_array
    out: []

outputs: []

manabuishii avatar Nov 14 '18 08:11 manabuishii

Hi @manabuishii I would prefer to keep this. In a way this is valid CWL, and indeed we have clients who do funny things with their workflows and end up with workflows with no outputs. This is a good check on the executor.

ghost avatar Nov 14 '18 11:11 ghost

I think this has been fixed already, @manabuishii ? Or is there anything pending so that this issue can be closed? Thanks!

kinow avatar Aug 31 '22 20:08 kinow

Hey - @manabuishii - is this OK now? Just trying to do a little ticket grooming.

swzCuroverse avatar Oct 06 '22 19:10 swzCuroverse

Note: to find out where an old numbered section went, check the src/conf.py file :+1:

e.g. https://github.com/common-workflow-language/user_guide/blob/3ed85b81ecc6a16a3b91f4b8f822774cc3212faf/src/conf.py#L116

kinow avatar Oct 06 '22 20:10 kinow