common-workflow-language
Upgrading to Spring Boot 3
Description
Upgrading to Spring Boot 3
Motivation and Context
https://github.com/common-workflow-language/cwlviewer/pull/566#issuecomment-1735611928
Closes #576
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
Fixed one broken test today, three more to go. Two I know the reason, but not the solution. The other we had during the migration mongo->postgres, so I just need to find the notes about how to debug that one (need to look at the query executed during the unit test...)
The last test failing is due to Hibernate/Postgres. At least the others were fixed (at least locally, waiting for GH Actions). Time to search for issues/SO's/etc now :grimacing:
Finally had some time to give it another try, and managed to get all tests passing. Still a couple of points pending, and I will try to do some manual tests using existing CWL workflows. But feel free to review or test it if you have time -- I will test it next time I have a chance, but at least we now have a working build with updated Spring Boot and dependencies :wave:
@kinow Shall I merge?
Let me rebase, and then do some quick tests with Docker locally. Then it should be ready to go! :boom:
@mr-c rebased, GH Actions passed, then checked out latest commit, ran docker compose up, uploaded some CWL files, they were all correctly rendered. I think it's ready to be merged now :slightly_smiling_face: Thanks!