Martin Kinkelin
Martin Kinkelin
There shouldn't be any need to list the features explicitly (those that are implied by `-mcpu`), that's what I've been trying to say the whole time. Does it make any...
Okay so what clang e.g. does for x86_64 and `-march=nehalem` is adding these 2 IR function attributes: ``` "target-cpu"="nehalem" "target-features"="+cmov,+crc32,+cx16,+cx8,+fxsr,+mmx,+popcnt,+sahf,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87" ``` With LDC's `-mcpu=nehalem`, we only emit `"target-cpu"="nehalem"` and don't...
Hmm, looks like the non-musl tests are wrongly excluded? https://github.com/ldc-developers/ldc/blob/9db6d953149f4698bf017e0ac42f188f58e303a4/runtime/druntime/test/exceptions/Makefile#L40-L42 Maybe some weird Make behavior if the variable isn't defined?
Or the left-over auto-detection in the Makefile now breaks it because the GHA Linux images might come with an unexpected `apk` tool now? https://github.com/ldc-developers/ldc/blob/9db6d953149f4698bf017e0ac42f188f58e303a4/runtime/druntime/test/exceptions/Makefile#L6-L11
AFAICT from the CI logs, it's got to be the latter - `unknown_gc` (excluded with `IS_MUSL=1`) is included on macOS, but not glibc Linux: https://github.com/ldc-developers/ldc/blob/9db6d953149f4698bf017e0ac42f188f58e303a4/runtime/druntime/test/exceptions/Makefile#L18-L20
Oh god; thx for digging! > we can just use that, instead of looking for `apk`. Yeah, *we* here for LDC can, but I think I've added this apk-logic upstream...
Test case from https://github.com/ldc-developers/ldc/issues/4246#issuecomment-1308175222: ```D struct Result(Type) { Type get() { assert(0); } alias get this; this(ref Result) {} } float dotProduct() { Result!float got; return got; } ``` The...
Just because the DMD codegenerator doesn't hick up on the wrong AST types doesn't mean this is an LDC issue.
> so I need to bisect If the `!167190` is stable, you could dump the IR via `-output-ll -disable-verify`, and grep for the return instruction, to get at the problematic...
Almost green; AFAICT just need to check: * `compilable/fix19983.c`: duplicate `extern` variable declarations in the same C scope * Win64: `runnable/testpdb.d` * AArch64: `std.internal.math.gammafunction` unittests (possibly macOS only with 64-bit...