Martin Kinkelin

Results 756 comments of Martin Kinkelin

> I actually did and it didn't make a difference for x86-64 That doesn't make a lot of sense - with `-frame-pointer=all` for the new code? Anyway, doesn't matter anymore....

> I may make a PR with this change if wanted. Well that sounds great to me! :) > In this case, I feel atos should only be linked in...

Lol, Apple is really hilarious, worse than Microsoft ever was.

Any help in #4943 would be appreciated, in case you e.g. have the ability to test it locally - it would e.g. be good to know whether the test failures...

@calvin2021y: I meant testing on Alpine AArch64, using a supported LLVM version < 21.

Oof, pretty discouraging first test results for CI.

> For the record https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGDecl.cpp#L1375 has just `Addr` now no `Size`. Yep, but that's LLVM 22, not 21: https://github.com/llvm/llvm-project/commit/c23b4fbdbb70f04e637b488416d8e42449bfa1fb

Okay, looking much better now; the problem was a GC2Stack regression introduced in a recent prepare-for-LLVM-21 PR. - Basically just a `std.json` unittest regression remaining (with enabled optimizations only), and...

The `std.json` regression smells like an LLVM regression unfortunately. This asserts with `-O`: ```D import std.json; void main() { JSONValue j; j["rating"] = 42; } ``` ``` std.json.JSONException@std/json.d(337): JSONValue is...

Hmm, `std.json` now passes after #5029, using the same LLVM v21.1.7 as before. `std.json` itself wasn't touched at all. So the LLVM bug might still be lingering in v21.1.8 after...