Martin Kinkelin

Results 756 comments of Martin Kinkelin

> I think your fix https://github.com/ldc-developers/ldc/pull/5015 was either wrong for old LLVM versions or it was already broken for old LLVM versions. I very much doubt so - we surely...

What I'd find more interesting test-wise is the handling of non-in-place-constructed temporaries. I suspect we don't declare their lifetime end at the end of the statement; and these temporaries could...

The actual problem is this: ```D extern(C): // this! struct S { this(this) {} } S sretReturn_NRVO() { S ret; return ret; } S sretReturn_RVO() { return S(); } ```...

> Since this could be considered a bugfix for the broken remux playback, should this be targeting the 10.11 release branch? I can re-target obviously; I just can't confirm that...

You're now switching to the emit-into-every-referencing-object-file TI emission scheme for *all* classes, and all symbols they reference. Not restricting it to C++ classes, nor as the hacky 'solution' this is...

https://github.com/dlang/dub/tree/master/test/issue2698-cimportpaths-broken-with-dmd-ldc?