ldc icon indicating copy to clipboard operation
ldc copied to clipboard

CI: show logs

Open the-horo opened this issue 4 months ago • 10 comments

the-horo avatar Aug 18 '25 12:08 the-horo

Let's see if there's anything interesting happening with druntime-test-exceptions-release

the-horo avatar Aug 18 '25 12:08 the-horo

Hmm, looks like the non-musl tests are wrongly excluded? https://github.com/ldc-developers/ldc/blob/9db6d953149f4698bf017e0ac42f188f58e303a4/runtime/druntime/test/exceptions/Makefile#L40-L42

Maybe some weird Make behavior if the variable isn't defined?

kinke avatar Aug 18 '25 13:08 kinke

Or the left-over auto-detection in the Makefile now breaks it because the GHA Linux images might come with an unexpected apk tool now? https://github.com/ldc-developers/ldc/blob/9db6d953149f4698bf017e0ac42f188f58e303a4/runtime/druntime/test/exceptions/Makefile#L6-L11

kinke avatar Aug 18 '25 13:08 kinke

AFAICT from the CI logs, it's got to be the latter - unknown_gc (excluded with IS_MUSL=1) is included on macOS, but not glibc Linux: https://github.com/ldc-developers/ldc/blob/9db6d953149f4698bf017e0ac42f188f58e303a4/runtime/druntime/test/exceptions/Makefile#L18-L20

kinke avatar Aug 18 '25 13:08 kinke

Or the left-over auto-detection in the Makefile now breaks it because the GHA Linux images might come with an unexpected apk tool now?

It doesn't seem apk exists by default. Let's see if it somehow pops up by the time the tests are run

the-horo avatar Aug 18 '25 14:08 the-horo

Or the left-over auto-detection in the Makefile now breaks it because the GHA Linux images might come with an unexpected apk tool now?

It doesn't seem apk exists by default. Let's see if it somehow pops up by the time the tests are run

Nope, it's still not there. But the tests "detect" it anyways. Is the make shell function doing something we don't expect?

the-horo avatar Aug 18 '25 16:08 the-horo

Alright, I genuinely don't have any idea how this is possible: https://github.com/ldc-developers/ldc/blob/21166150b6a38564fa3c7485d6d9f1c30c0fb222/runtime/druntime/test/exceptions/Makefile#L6-L19

  • linux-aarch64
1817: 1
1817: 1
1817: 127
1817: 127
1817: Makefile:14: ~~~ musl detected
  • alpine
1822: /sbin/apk 0
1822: /sbin/apk 1 0
1822: /sbin/apk 0
1822: /sbin/apk 1 0
1822: Makefile:14: ~~~ musl detected

the-horo avatar Aug 18 '25 17:08 the-horo

  • linux aarch64

https://github.com/ldc-developers/ldc/blob/6171ff18cce96b97d10445300715e268f00f1073/runtime/druntime/test/exceptions/Makefile#L6-L9

1817: 0
1817: 1 0
1817: 0
1817: 1 0
1817: Makefile:15: ~~~ musl 1

Why is &> changing the exit status???

the-horo avatar Aug 18 '25 17:08 the-horo

/bin/sh is dash in the runner, which doesn't understand &>.


There's already https://github.com/ldc-developers/ldc/blob/9db6d953149f4698bf017e0ac42f188f58e303a4/runtime/DRuntimeIntegrationTests.cmake#L60-L63 we can just use that, instead of looking for apk. Does that sound good @kinke?

the-horo avatar Aug 18 '25 18:08 the-horo

Oh god; thx for digging!

we can just use that, instead of looking for apk.

Yeah, we here for LDC can, but I think I've added this apk-logic upstream when adding the Alpine CI job (for DMD). So we could skip the logic for IN_LDC, but DMD upstream needs a solution.

kinke avatar Aug 18 '25 19:08 kinke