K.I. (Dennis) Jung

Results 58 comments of K.I. (Dennis) Jung

@allisonport-db there are overrided 'equals' class in `DataType`. So you want `equivalent` to be act different with this, right?

@allisonport-db thanks. 1 more question... Could you let me know which build command should I use for testing the result after fix?

@allisonport-db hello. For test, when I run ``` Literal.of(BigDecimal.valueOf(2).setScale(1)) ``` it shows ``` overloaded method value of with alternatives: [error] (x$1: Byte)io.delta.standalone.expressions.Literal [error] (x$1: java.sql.Timestamp)io.delta.standalone.expressions.Literal [error] (x$1: String)io.delta.standalone.expressions.Literal [error] (x$1:...

@allisonport-db thanks, you were right. As you said there are exception on ``` new EqualTo(Literal.of(BigDecimal.valueOf(2).setScale(1)), Literal.of(BigDecimal.valueOf(2).setScale(2))) ``` So are you meaning to change comparing logic something like following? ``` Literal.of(BigDecimal.valueOf(2).setScale(1)).equivalent(Literal.of(BigDecimal.valueOf(2).setScale(2)))...

@allisonport-db thanks. More clear. For now, it seems `DataType::equivalent` should compare only type name, and `DecimalType::equivalent` should compare `precision` and `scale`. So, for `DataType::equivalent` ``` public boolean equivalent(DataType dt) {...

Hope I could help on this too.

@antonioaltamura I also asked to manager. He looks like finding supporter for managing this project.

@ohjames I am using this on Angular 1.5.8, and it works perfectly fine~

@phobos-labs It looks like good idea to show fail result, but it does not show broadcasts when loading file that does not exists. Could you look on it?