K.I. (Dennis) Jung

Results 58 comments of K.I. (Dennis) Jung

Agree with this. Maybe it could be better to separate pages for each subtitles (Constructs/Structs/Classes...) into subpages 👀

@jsteinich @xiehan depend on code, seems `object`, `list`, `set`, `map` is being handled inside. So for this update, is it mean that type `tuple` also needs to be handled. Is...

@jsteinich could you check the following? https://github.com/hashicorp/terraform-cdk/pull/2964 Seems it changes as ``` list(tuple([string, string, number])) => tuple[string,string,number][] ``` If it seems okay, I'll include several test cases 👍

@ysimonson hello. Bit a long time, and started to work on node SDK. There are some question, that when I call `createVertex` API, it always returns ``` { wrappers_: null,...

There were sometimes returning expected value, such as returning `true` like below ``` { wrappers_: null, messageId_: undefined, arrayIndexOffset_: -1, array: [ true ], pivot_: 1.7976931348623157e+308, convertedPrimitiveFields_: {} } ```...

@ysimonson ~~Thanks for feedback. But when I send proper 16-byte uuid, in most of cases it returns the following format (empty array) https://github.com/indradb/indradb/issues/229#issuecomment-1565158483 As I think it should return true/false...

Not quite sure, but seems returning empty array is just happening that node indicates array with false as empty one. So I think this issue is okay. But for the...

@samkirton thanks! I'll look on it.

@mingrammer good job! Currently working on it?

@ysimonson about logging, - In `ping`, seems this is just checking proto server connection goes well, and not checking actual server runs well or not. Will it be okay? https://github.com/indradb/indradb/blob/master/proto/src/server.rs#L196...