coding-interview-university
coding-interview-university copied to clipboard
jwasham
Translation : Korean
I'd like to translate to Korean! Anyone who wants to participate, plz feel free to do so. Fork this repo and make pull requests with any part translated PR for first part(merged) : https://github.com/jwasham/google-interview-university/pull/119 PR for second part(current) : https://github.com/jwasham/google-interview-university/pull/132
Thank you!
Fork the project and make a README-ko.md in translations directory. Make a pull request to collaborate and commit to. Let me know when it's ready to pull.
@jwasham I made pull request with just a few line and link to the issue. Is it enough for beginning? @Hanney-Ryu @djKooks Of course, I really appreciate your help!
@minias Thanks! That link would match to a part of 'Follow Along with me' paragraph
@jwasham Could you add a link for Korean translation with this issue(https://github.com/jwasham/google-interview-university/issues/118) at main README.md so that more people could participate?
And would it be possible to add me as a contributer for this repo?
@jwasham I thinks it is proper to merge this PR and start new one! pretty much part is translated into Korean pleae merge the PR
@strollkim I want to participate as well. I forked and translated. PR #146.
Please let me know if I'm making changes in a wrong way!
Reopening. There is still a lot of work left, and I don't know if there is stuff waiting to be merged.
is this done? I think the repo was deleted. @strollkim @jwasham Can i make new repo (on me) to create new pull request for new commits?
Hi. This repo seems on going but the previous ones(1 and 2) are not alive. So I forked new one and am having done which is not translated yet. Anyone who can still contribute please join me. Any problem exists about this, @strollkim @jwasham @joonas-yoon please let me know.
Thanks, but still alive. Make your commit on this pull request(https://github.com/jwasham/coding-interview-university/pull/397)
Hi, I discovered this repo of John Washam and would like to participate in translating it in Korean, if it is still ongoing (as I see I could fork the project !) I know I joined a bit later, but better later than never !
Hi, my PR #397 was merged and closed. I think you could fork and create new PR from your one :)
Hi, if this translation project still going on, I’m down to participate.
Hello! I'd like to contribute to translating it to Korean, but the links above seem to be broken. Could someone please tell me how I can participate? (Sorry if this is a basic question, I'm completely new to Github) Thanks!
@jwasham Looks like some contributors are confused where to make a PR. Would you make a official decision?
for example: "you don't consider this issue (#118). Just fork, edit, then push to this repo's master branch".
Actually I'm confused why this PR is still open.
@roeniss I agree with above comment. but i think all issues about translation are like a sign to gather the people, who want to contribute.
BTW, this is not PR. it's an issue.
you can start your PR for translating, then come here and can notify your contribution to new people :)
@joonas-yoon thank you for correcting my word, I was confused for a second. Like you said, it would be good to use this issue as sort of a release board and just make their own pr as they go.