Igor Savin comments

Results 605 comments of


                                            Igor Savin

Migrations: Add lifecycle callbacks

OK, I can see how this is useful. Shouldn't be too complicated to implement either.

Migrations: Add lifecycle callbacks

@emahuni Would you be open to submit a PR for this?

batchInsert not returning all ids

@asngeo PR would be welcome!

fix: recover from broken connection

@rluvaton Could you please review?

fix: recover from broken connection

This looks good, thank you!

Update operations do not support joins

I could try giving it a shot, but I have no idea how complicated this is going to be. @elhigu any pointers where to start?

Update operations do not support joins

@JQuezada0 Yes, that would be great! You might want to take a look at how DELETE with joins was implemented: https://github.com/knex/knex/pull/4568 https://github.com/knex/knex/pull/4800 https://github.com/knex/knex/pull/5016

Update operations do not support joins

Pull requests are very welcome.

Update operations do not support joins

@joelanman PR would be appreciated!

Connection: forcibly close stream if close() is called while the connection is blocked

@SimonWoolf Ping? Are you still open to update the PR?