Igor Savin

Results 605 comments of Igor Savin

@cressie176 Could you please take a look?

@sarahdayan Are you open to getting additional maintainers?

@metcoder95 So what would be your recommendation here? Is `cores - 1` a sensible recommendation for thread settings? (so that there is still one core left for main thread).

@climba03003 Why not use https://www.npmjs.com/package/@fastify/busboy?

If this proposal is accepted, I can send in a PR!

awesome! can you give me write and merge pr permissions so that I could start, and I'll see what other engineers could join in later?

@cthackers Sure, here's the one to get started: https://github.com/cthackers/adm-zip/pull/469

@JUtupe Actually, better approach would be to implement `Closeable` interface for the RabbitMQ plugin class. Then ktor will automatically call the disposal logic on shutdown.

@JUtupe You can try calling ` this.application.dispose()` in test and then try firing an event; it should fail because connection should be already destroyed.