knex icon indicating copy to clipboard operation
knex copied to clipboard

fix: recover from broken connection

Open beltschatsar opened this issue 2 years ago • 1 comments

Fixes https://github.com/knex/knex/issues/5732

beltschatsar avatar Dec 18 '23 18:12 beltschatsar

@OlivierCavadenti or @kibertoad is there anything needed to merge this ? Not having this fix can lead to a backend not responding at all, because some events (ex: connection kill) would lead to broken connection clogging the pool.

beltschatsar avatar Jan 16 '24 21:01 beltschatsar

@kibertoad Kindly ask again to merge this. As said before, not having this fix can lead to a backend not responding at all, because some events (ex: alter system kill session) would prevent to dispose an unusable connection when validating this connection .

beltschatsar avatar Mar 14 '24 14:03 beltschatsar

It would be great to add NJS-521 and NJS-500 as part of PR. We hit this same issue when connecting to OCI. As a workaround, leveraged pnpm patch <pkg name>@<version> to apply patch and seems to work very well.

Happy to offer my services to help push this along.

Thank you maintainers!

robmcguinness avatar May 03 '24 02:05 robmcguinness

@rluvaton Could you please review?

kibertoad avatar May 14 '24 13:05 kibertoad

This looks good, thank you!

kibertoad avatar May 14 '24 13:05 kibertoad

Can we please have a patch tag/release and push a new npm package for this change to be released? Thank you!

enov avatar Aug 13 '24 22:08 enov