Igor Savin

Results 605 comments of Igor Savin

@elhigu We have this code in generic Tablecompiler: ``` // If no name was specified for this index, we will create one using a basic // convention of the table...

@sebastian-nowak I'm mostly concerned that at this point changing logic would be something of a breaking change, because it is possible that someone wrote constraint-manipulating SQL (e. g. for dropping...

@elhigu Should we propagate knex logger to tarn by default if no other logger is specified, btw?

@CodyEakins Why not just use Knex API for running migrations then? https://knexjs.org/#Migrations-API (probably could be documented better) Personally I find knex CLI cumbersome and much prefer writing JS scripts for...

@CodyEakins I'm not sure it's a bug, considering that I don't think we ever supported passing knex instance from knexfile.js, only configuration itself. I would consider it more of an...

@CodyEakins To the same effect you could be calling `node scripts/migrateLatest.js && yarn run start` that would be invoking `knex.migrate.latest(yourConfig)` inside of it. I guess --knexpath needs better explanation about...

We can't drop existing flags for the sake of backwards compatibility. However, we would accept PRs that would implement more intuitive and convenient to use configuration approaches.

@lorefnon yes, that sounds perfect

@cs97dah Hey! This does look interesting, but index.ts is getting very cluttered by now. Maybe you could extract some of the code outside of it?