Igor Savin comments

Results 605 comments of


                                            Igor Savin

No error handling for tedious error "ESOCKET"on connection

Would you consider sending PR for this?

No error handling for tedious error "ESOCKET"on connection

don't think so, feel free to send a PR!

connection.close causes process to die and error is uncatchable

@cressie176 Maybe we can allow registering some kind of an error handler that we would use for publishing these errors?

connection.close causes process to die and error is uncatchable

`but does beg the question, what would we do if the handler_error handler failed.` handler_error would be handled purely in userspace, right? In that case I would argue that it's...

Add typescript type definitions

@squaremo What is the final decision on that, do we want it in? I can fix the conflict in this PR if it is OK in general.

Replace url-parse lib with native URL interface

@jonaswalden Could you please rebase this?

GitHub Actions CI

@squaremo Not sure if this can be triggered by a non-maintainer and/if it needs to be merged first, could you take a look?

GitHub Actions CI

@squaremo From my understanding, if there were no GitHub Actions before, it needs to be merged before activates.

GitHub Actions CI

Sure, I can do this later today.

Typescript support

@vkarpov15 Do you need help with this? I can contribute to the effort, although probably can't type everything just by myself :D