amqplib icon indicating copy to clipboard operation
amqplib copied to clipboard

GitHub Actions CI

Open kibertoad opened this issue 4 years ago • 7 comments

kibertoad avatar Aug 26 '21 09:08 kibertoad

@squaremo Not sure if this can be triggered by a non-maintainer and/if it needs to be merged first, could you take a look?

kibertoad avatar Aug 26 '21 09:08 kibertoad

can we merge this?

jimmywarting avatar Oct 11 '21 17:10 jimmywarting

Any idea why this doesn't run the actions? So far as I can tell, it's not restricted to PRs only in my account.

squaremo avatar Oct 12 '21 06:10 squaremo

@squaremo From my understanding, if there were no GitHub Actions before, it needs to be merged before activates.

kibertoad avatar Oct 12 '21 06:10 kibertoad

From my understanding, if there were no GitHub Actions before, it needs to be merged before activates.

In that case, can we split this into two PRs:

  1. Adds workflow that runs tests
  2. Adds linting and dependabot auto-merge

We can merge the first one to get actions running, then the second will show any problems.

squaremo avatar Oct 12 '21 06:10 squaremo

(I know it is odd for me to talk about splitting a PR, when I only very occasionally have time to look at things :-/ But, good practice is good practice, and I have some time right now ..)

squaremo avatar Oct 12 '21 06:10 squaremo

Sure, I can do this later today.

kibertoad avatar Oct 12 '21 06:10 kibertoad

this was already implemented

kibertoad avatar Jan 16 '23 21:01 kibertoad