amqplib
amqplib copied to clipboard
Replace url-parse lib with native URL interface
Engine specified to node >= 10.
Should be no need for a lib to polyfill the URL interface or implement the legacy url.parse in a browser environment.
Thanks @jonaswalden.
https://github.com/amqp-node/amqplib/commit/7acbfd72330b835e1ffdad3daf78c222d1256142 details why url-parse was introduced in the first place. I suspect that now amqplib only supports node 10 and up, the standard url parser will be fine. Unless this isn't so, I'm in favour of this PR - the fewer 3rd party libs we import the better
@jonaswalden Could you please rebase this?
@cressie176 wow, ok. good to know! seems like that's covered https://github.com/BonnierNews/amqplib/blob/main/test/connect.js#L54
hold on, I screwed something up
hold on, I screwed something up
solved.
@kibertoad good to go?
@jonaswalden Do you need any help with finishing this?